Posted: Mon Jan 14, 2019 8:53 pm Post subject: Shwedagon Pagoda and round ending (game 72815) (solved)
I this game currently in progress, one player lost Qin Shi Huang because of least stability, and the reason for this was that Shwedagon Pagoda effect was lost before Discard Turmoil Cards phase.
By game rules, Discard Turmoil Cards phase happens after Famine during resolution, and I understand that it is before the end of round. On the other hand, Shwedagon Pagoda effect should last until the end of round. Seems that these are done vice versa in Mabiweb.
I think you are right, from the rulebook it's pretty clear that "Discard Turmoil" phase comes before the end of round, so this is a bug.
And it's unfortunate because I don't know if I can fix this one. All the bugs I have been fixing these past months were usually simple one-line changes or little more, very limited in scope and so they were easy to fix and especially to test (testing is the really time-consuming part).
This one looks different, it could require changes with broad implications and it would be a nightmare to test, and I stopped working on Nations almost 2 years ago, so I don't remember most of the code anymore.
This is the kind of bug that should have come out just after release. I will take a deeper look and try something but I'm not sure I can fix this now.
I don't know how game state is saved and what can be changed, but is it possible to set Qin Shi Huang back to player who lost it? We haven't been progressing in the game after we noticed the event, so it would correct the situation in this game.
I have just updated the new code with a fix for this bug. As I said before, this required some significant changes, and I couldn't test much, so it's possible I introduced new bugs. If you are reading these, please try to pay attention at the end of the round and report anything wrong or suspicious. In case of problems I will revert back to the previous version.