Posted: Tue Jan 10, 2017 10:35 am Post subject: Archimedes (confirmed, solved)
It looks like the implementation adds private architects from Archimedes or Alhambra to your resources.
In Game ID=63319 I replaced Archimedes with another advisor, but the extra architect stayed in my supply (I didn't try to use it, but I assume it would've been available).
I think cards like Archimedes could be implemented similar to Royal Society: that they provide an once per round action to take a private architect when you build your wonder.
At least the architect should be no longer available when Archimedes leaves the game...
Yes, you are right, in the current implementation there is a "personal supply" of private architects cumulating those coming from different sources (Archimedes, Egypt, Alhambra and Marie Curie). This was convenient to implement, treating all of them with the same code, but I didn't think of the problem of removing the architect together with the card. When you use a private architect it's impossible to know where it was coming from if you have multiple sources.
I will have to change and implement them like you suggest: each card with its own special action. It's a bit of work so it will take some time.
Ok, since the complete change I described above is quite some work, and it would break the existing games, for now I have implemented a much simpler solution. So now private architecs are handled as before but when the advisor or wonder is removed it removes also the unused private architect.
The only issue can arise when the player has multiple sources of private architects and one of them is removed and one of the architecs was already used: in this case it is assumed it was coming from the card being removed (so, a very rare circumstance where we implicitely assume the player did the right move).