Author Message
MaBi
PostPosted: Fri Oct 29, 2021 8:25 am    Post subject:

I think I have fixed this bug, though I'm not 100% sure (I found what I believe was the problem in the code and fixed it, but I didn't test because setting up a game with all the right conditions to reproduce the bug is quite time consuming).
Kayser
PostPosted: Thu Oct 28, 2021 4:28 pm    Post subject: Log shows only one worker returned from Northwest Passage

http://www.mabiweb.com/modules.php?name=GM_Nations&g_id=88170&op=view_game_reset

adderat: explore 'Northwest Passage' (Natural Wonder completed)
adderat: place 'Northwest Passage'
adderat: return to (Stability +3)
Kayser: hire an architect paying 1 (Wonder completed)

There seems to have been an issue with the logging here. According to adderat, two meeples were actually returned, but the second one was not reflected in the log. A clue could be that adderat selected the first meeple to be returned to stability track, then the second meeple was auto-determined to food track, because stability track was then full.
Kayser
PostPosted: Thu Oct 28, 2021 4:24 pm    Post subject: Re: Victoria Falls + Anglo-Afghan War

Logitude wrote:
Kayser wrote:
On the topic of Victoria Falls, is it possible to re-roll the outcome of the Victoria Falls draw by reseting the turn and placing the wonder again?


You can reset your turn, which undoes the reveal, but once you place Victoria Falls again, it reveals the same cards, so it doesn’t offer a way to ensure favorable cards appear.

At that point, you have no choice in what to do on your turn other than where to place Victoria Falls, so it’s not like you can view the revealed cards and change your mind about whether to place the falls. However, it could theoretically help you decide what wonder to replace if you have to replace one. There are many scenarios I can think of where knowing which and how many colonies will be revealed and which cards will not appear in the next round, if there is one, can help you determine which wonder to replace.

Still though, I think it’s not sufficiently common that it’s necessary to address, since MaBi is only fixing bugs at this point, and I think the fix would be a major task. But, of course, that’s up to him.


Agree. It would have been critical if you would be able to re-roll the complete outcome, but just for the purpose of determining which wonder to replace, I can live with that drawback.
Logitude
PostPosted: Wed Oct 13, 2021 11:02 pm    Post subject: Re: Victoria Falls + Anglo-Afghan War

Kayser wrote:
On the topic of Victoria Falls, is it possible to re-roll the outcome of the Victoria Falls draw by reseting the turn and placing the wonder again?


You can reset your turn, which undoes the reveal, but once you place Victoria Falls again, it reveals the same cards, so it doesn’t offer a way to ensure favorable cards appear.

At that point, you have no choice in what to do on your turn other than where to place Victoria Falls, so it’s not like you can view the revealed cards and change your mind about whether to place the falls. However, it could theoretically help you decide what wonder to replace if you have to replace one. There are many scenarios I can think of where knowing which and how many colonies will be revealed and which cards will not appear in the next round, if there is one, can help you determine which wonder to replace.

Still though, I think it’s not sufficiently common that it’s necessary to address, since MaBi is only fixing bugs at this point, and I think the fix would be a major task. But, of course, that’s up to him.
Kayser
PostPosted: Wed Oct 13, 2021 4:13 pm    Post subject: Re: Victoria Falls + Anglo-Afghan War

On the topic of Victoria Falls, is it possible to re-roll the outcome of the Victoria Falls draw by reseting the turn and placing the wonder again?
MaBi
PostPosted: Wed Oct 13, 2021 12:58 pm    Post subject: Re: Victoria Falls + Anglo-Afghan War

Kayser wrote:
Just saw this in game 87925

This one was easy... fixed.
Kayser
PostPosted: Tue Oct 12, 2021 9:23 pm    Post subject: Victoria Falls + Anglo-Afghan War

Just saw this in game 87925

//
Tankare: place 'Victoria Falls' (replacing 'Porcelain Tower' ) (advisor 'Peter the Great' removed) ('Victoria Falls' effect: draw 20 cards pci:@Anglo-Afghan War@ found 3 Colonies)
//

bold part is not expected; expected: thumbnail of the progress card
magnivicen
PostPosted: Wed Oct 07, 2020 6:08 am    Post subject: Sorry no bug in game Game ID=82406

Sorry it is my mistake. Ignore previous message
magnivicen
PostPosted: Wed Oct 07, 2020 6:06 am    Post subject: Game ID=82406 august +2 not working

Despite having the highest military, no +2 ore from the august advisor. Game is played with players
Logitude
PostPosted: Fri Aug 21, 2020 6:56 pm    Post subject: Re: can't join a game

MaBi wrote:
I just checked, there was a space after "pandemic", so it actually was "pandemic ", and maybe that was the issue? I don't know how the other players joined, maybe they knew and added the space?
Anyway I have removed the space and if you try now with "pandemic" it should work.

Sounds like autocomplete vs. typing out the whole word.
MaBi
PostPosted: Fri Aug 21, 2020 5:43 pm    Post subject: Re: can't join a game

Dennis wrote:
In game 81945 the password is pandemic, but when I put it in it says incorrect password. Others have been able to enter the game so it does work.

I just checked, there was a space after "pandemic", so it actually was "pandemic ", and maybe that was the issue? I don't know how the other players joined, maybe they knew and added the space?
Anyway I have removed the space and if you try now with "pandemic" it should work.
Dennis
PostPosted: Wed Aug 19, 2020 3:06 am    Post subject: can't join a game

In game 81945 the password is pandemic, but when I put it in it says incorrect password. Others have been able to enter the game so it does work.
MaBi
PostPosted: Mon Jun 29, 2020 7:33 pm    Post subject:

I see that the 80018 game has finally finished in the regular way, hopefully the bug is now fixed.
Logitude
PostPosted: Fri Jun 26, 2020 2:41 pm    Post subject:

"This change won't affect that."

-every programmer ever
MaBi
PostPosted: Fri Jun 26, 2020 8:06 am    Post subject:

Ok, I see that the other game I resurrected (77878) did finish correctly.
I think I have found the cause of the problem (not 100% sure yet, I need to fix it and test), it's probably due to an expiring session. If you load the game and take too much time to make your move then your session will expire and when you save you get an error. If this happen on the very last move, the game state will not be updated but the entry in the game manager will (and this is a bug of course, introduced recently when I changed the way an expiring session is handled).
I guess that in both cases Timgagnon left the game open in the browser until the session expired.

Sorry for the problems, I will try to fix this over the weekend.